Repository navigation
A Run's outcome says whether its Engine step started, and the run record carries it (#757's first part, record 0201) - #770
Conversation
…ord carries it (#757's first part, record 0200) The run job hands on its Engine step's outcome; apply writes engine_started into outcome/1, false only where GitHub skipped the step, and leaves it out where the job said nothing. The records port carries it into the run record and keeps it with a kept outcome. Nothing reads it yet. The record number is provisional. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Code Review
This pull request implements tracking of whether a Run's Engine step started (Issue 757). It introduces an "engine_started" boolean field in the run records and outcomes, which is determined by parsing the outcome of the "engine" step from GitHub Actions (via the "NEEDS" environment variable). The changes span across adapters, controller, harness, schemas, workflow validation tools, and include a new decision document and comprehensive tests. Since there are no review comments, I have no feedback to provide.
…art of it is held by a test (#757's first part, record 0200) The Claude review's findings: engines() read an earlier record whose word could never reach a run record; the entry's reading from records dated before the pass, the run record's boolean and the outcome read's guard were held by no test. Record 0200 names the rollback cost and what is not verified on GitHub. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 15 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
's first part, record 0200) Carbon's finding on b02ece0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t, record 0201) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t, record 0201) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # adapters/records.py # controller/__main__.py # tests/test_controller.py # tools/mutants.py
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gives the Engine's word on a failed Run (#757's first part, record 0201) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t, record 0201) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # adapters/records.py
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>



User description
Refs #757 ("A Run that ended environment does not use up the item's run ceiling"): its first part, by the Factory Builder's ruling of 2026-11-12. It does not close the issue; the counting is the next pull request, rebuilt from #769 on this one.
This changes
harness/and.github/workflows/, a model Lens's inputs: the Maintainer approves it by hand as donpetry-bot, and the Factory never approves it. It is heldfactory:hands-off.What changes
engine,${{ steps.engine.outcome }}. GitHub skips the step once a step before it failed, as the CLI install did in the runner DNS outageapply(harness/apply_step.py)outcome/1'sengine_started: false where the output isskipped, true where it issuccess,failureorcancelled, left out otherwiseoutcome/1,run-recordengine_startedrecords.engines, besiderecords.begun)enginesto the records porttools/check_workflows.pyoutcome, one of four words GitHub gives, beside a step's own output; its copy ofrun-jobs.ymlcarries the new outputIt fails closed: the field says false only where GitHub said the Engine step was skipped. A missing output, a job killed before it handed on its outputs, an unknown word, or an outcome from before this change leaves it out, and the next change will count such a Run as one that may have reached the model.
The record is
docs/decisions/0201-…. 0201 is the Factory Builder's number, behind 0197 (#774), 0198 (#761), 0199 (#760) and 0200. Until those merge, thecheckslegs are red on "records are numbered from 0001 with no gap", and nothing else fails. The number is confirmed before the final push.Checks
tests/test_steps.py::test_apply_says_whether_the_engine_step_started(each word, the live workflow's output andNEEDS),tests/test_adapters.py::test_whether_the_engine_started_is_read_with_the_outcome_and_kept_by_its_run_and_attempt, the outcome's own read intest_a_runs_outcome_is_read_from_its_one_file_and_held_to_outcome_1, the entry intests/test_controller.py, and the expression rule intests/test_tools.py.make checksis clean but for the provisional number. The desk's unfiltered run at a46e5c7, the record renumbered in a copy to clear the gap: 6,900 of 6,900 mutants killed. After main's merge, every mutant ofcontroller/__main__.pyandadapters/records.pywas run again: 205 of 205 killed.steps.engine.outcomereadsskippedafter an earlier step failed. GitHub's documentation givessteps.<id>.outcomeas one of success, failure, cancelled or skipped. No trial has run, since a session may not dispatch a workflow. If it reads otherwise, the field is left out, and the Run counts as it does today.Protected paths
.github/workflows/,harness/,adapters/,controller/,schemas/,tests/andtools/are protected or reported paths: pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder (its ruling of 2026-11-12 on #757).harness/and the workflows are model Lens inputs, so the Maintainer approves this pull request by hand.Reviews
engine_startedto a boolean; the outcome read's guard has a test and a mutant;engines()reads the last record alone, sinceknownkeeps a fault from it alone and an earlier word could never reach a run record. Rollback: an older Release reads a newer outcome as nooutcome/1, named as a cost in record 0201, asbegan_atalready isprevious[-2:]bound is gone, sinceengines()reads the last record alone (a46e5c7). Theapplyjob'sNEEDS: ${{ toJSON(needs) }}is held by the new test's read of the live workflow, and by everyapplytest, since without it nothing is read🤖 Generated with Claude Code
CodeAnt-AI Description
Record whether a run reached the Engine
What Changed
Impact
✅ Identify runs that never reached the model✅ Preserve Engine-start status across records✅ Avoid false “not started” results when status is unavailable💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.